Re: [Qemu-devel] [PATCH v7 08/11] tests: extend qmp test with preconfig checks

[Eric Blake]

On 05/04/2018 03:37 AM, Igor Mammedov wrote:
> Add permission checks for commands at 'preconfig' stage.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---

> +++ b/tests/qmp-test.c
> @@ -392,6 +392,49 @@ static void add_query_tests(QmpSchema *schema)
>       }
>   }
>   
> +static bool qmp_rsp_is_err(QDict *rsp)
> +{
> +    QDict *error = qdict_get_qdict(rsp, "error");
> +    QDECREF(rsp);
> +    return !!error;

At first glance, I was worried that this was a use-after-free; but as 
you are not actually dereferencing error, but merely checking whether 
the pointer was non-NULL (which works even if the pointer has gone stale 
in the meantime due to the QDECREF), you are okay.

> +}
> +
> +static void test_qmp_preconfig(void)
> +{
> +    QDict *rsp, *ret;
> +    QTestState *qs = qtest_startf("%s --preconfig", common_args);
> +
> +    /* preconfig state */
> +    /* enabled commands, no error expected  */
> +    g_assert(!qmp_rsp_is_err(qtest_qmp(qs, "{ 'execute': 'query-commands' 
> }")));
> +
> +    /* forbidden commands, expected error */
> +    g_assert(qmp_rsp_is_err(qtest_qmp(qs, "{ 'execute': 'query-cpus' }")));
> +
> +    /* check that query-status returns preconfig state */
> +    rsp = qtest_qmp(qs, "{ 'execute': 'query-status' }");
> +    ret = qdict_get_qdict(rsp, "return");
> +    g_assert(ret);
> +    g_assert_cmpstr(qdict_get_try_str(ret, "status"), ==, "preconfig");
> +    QDECREF(rsp);
> +
> +    /* exit preconfig state */
> +    g_assert(!qmp_rsp_is_err(qtest_qmp(qs, "{ 'execute': 'exit-preconfig' 
> }")));
> +    qtest_qmp_eventwait(qs, "RESUME");
> +
> +    /* check that query-status returns running state */
> +    rsp = qtest_qmp(qs, "{ 'execute': 'query-status' }");
> +    ret = qdict_get_qdict(rsp, "return");
> +    g_assert(ret);
> +    g_assert_cmpstr(qdict_get_try_str(ret, "status"), ==, "running");
> +    QDECREF(rsp);
> +
> +    /* enabled commands, no error expected  */
> +    g_assert(!qmp_rsp_is_err(qtest_qmp(qs, "{ 'execute': 'query-cpus' }")));

It would also be worth testing that a second exit-preconfig fails, now 
that you are no longer in preconfig state.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org