[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 09/12] qapi/block-core: add BitmapMapping an
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [RFC PATCH 09/12] qapi/block-core: add BitmapMapping and BitmapEntry structs |
Date: |
Wed, 16 May 2018 17:55:09 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/16/2018 05:37 PM, Eric Blake wrote:
>> +##
>> +# @BitmapMapping:
>> +#
>> +# List of described regions correlated to a named bitmap.
>> +#
>> +# @name: The name of the bitmap whose range is described here
>> +#
>> +# @entries: A list of zero or more @BitmapEntry elements representing
>> +# the range(s) described by the bitmap.
>
> Is it also worth documenting that the list will be in ascending order,
> with no overlaps (no two entries covering the same offset); and in fact
> with a gap between all entries (as otherwise those two consecutive
> entries could have been consolidated to one)?
>
Hm. I didn't necessarily want to guarantee the order, but being more
specific about the output will assist legibility of the spec.
I'll amend the documentation and make some stronger guarantees.
>> +#
>> +# Since: 2.13
>> +#
>> +##
>> +{ 'struct': 'BitmapMapping',
>> + 'data': { 'name': 'str',
>> + 'entries': [ 'BitmapEntry' ] } }
>> +
>> ##
>> # @BlockdevCacheInfo:
>> #
- [Qemu-devel] [RFC PATCH 00/12] qemu-img: add bitmap queries, John Snow, 2018/05/11
- [Qemu-devel] [RFC PATCH 02/12] qcow2/dirty-bitmap: cache loaded bitmaps, John Snow, 2018/05/11
- [Qemu-devel] [RFC PATCH 05/12] qcow2-bitmap: track bitmap type, John Snow, 2018/05/11
- [Qemu-devel] [RFC PATCH 09/12] qapi/block-core: add BitmapMapping and BitmapEntry structs, John Snow, 2018/05/11
- [Qemu-devel] [RFC PATCH 12/12] qemu-img: add bitmap clear, John Snow, 2018/05/11
- [Qemu-devel] [RFC PATCH 04/12] qcow2/dirty-bitmaps: load IN_USE bitmaps if disk is RO, John Snow, 2018/05/11
- [Qemu-devel] [RFC PATCH 03/12] block/qcow2-bitmap: avoid adjusting bm->flags for RO bitmaps, John Snow, 2018/05/11
- [Qemu-devel] [RFC PATCH 08/12] qjson: allow caller to ask for arbitrary indent, John Snow, 2018/05/11