qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] configure: Use strings command from cross devel


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] configure: Use strings command from cross development tools
Date: Tue, 15 May 2018 10:52:09 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 05/15/2018 10:04 AM, Peter Maydell wrote:

I'd much prefer this to be:

if $strings -a $TMPO | grep...

That's because if I have something like this in my environment:

STRINGS='/path/to/strings -a'

it will only work if you allow word splitting on my variable.

Conversely, if I have STRINGS='/path with spaces/to/strings'
in my environment it will only work if you don't do word
splitting on it :-)

Make convention has long been that /path with spaces/ is unacceptable for any of the typical tool replacements, and that you always perform unquoted (and thus word splitting) of a tool name. My most common example is EDITOR='emacs -nw'. You can always add a symlink to a tool from a path without spaces, if you want to provide a tool override to something that normally lives somewhere with spaces.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]