[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 05/28] fpu/softfloat: Canonicalize NaN fracti
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v5 05/28] fpu/softfloat: Canonicalize NaN fraction |
Date: |
Tue, 15 May 2018 12:44:00 +0100 |
User-agent: |
mu4e 1.1.0; emacs 26.1 |
Richard Henderson <address@hidden> writes:
> Shift the NaN fraction to a canonical position, much like we
> do for the fraction of normal numbers. This will facilitate
> manipulation of NaNs within the shared code paths.
>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> fpu/softfloat.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/fpu/softfloat.c b/fpu/softfloat.c
> index 0d17027379..607c4a78d5 100644
> --- a/fpu/softfloat.c
> +++ b/fpu/softfloat.c
> @@ -330,10 +330,11 @@ static FloatParts canonicalize(FloatParts part, const
> FloatFmt *parm,
> if (part.frac == 0) {
> part.cls = float_class_inf;
> } else {
> + part.frac <<= parm->frac_shift;
> #ifdef NO_SIGNALING_NANS
> part.cls = float_class_qnan;
> #else
> - int64_t msb = part.frac << (parm->frac_shift + 2);
> + int64_t msb = part.frac << 2;
> if ((msb < 0) == status->snan_bit_is_one) {
> part.cls = float_class_snan;
> } else {
> @@ -480,6 +481,7 @@ static FloatParts round_canonical(FloatParts p,
> float_status *s,
> case float_class_qnan:
> case float_class_snan:
> exp = exp_max;
> + frac >>= parm->frac_shift;
> break;
>
> default:
> @@ -503,6 +505,7 @@ static float16 float16_round_pack_canonical(FloatParts p,
> float_status *s)
> case float_class_dnan:
> return float16_default_nan(s);
> case float_class_msnan:
> + p.frac >>= float16_params.frac_shift;
> return float16_maybe_silence_nan(float16_pack_raw(p), s);
> default:
> p = round_canonical(p, s, &float16_params);
> @@ -521,6 +524,7 @@ static float32 float32_round_pack_canonical(FloatParts p,
> float_status *s)
> case float_class_dnan:
> return float32_default_nan(s);
> case float_class_msnan:
> + p.frac >>= float32_params.frac_shift;
> return float32_maybe_silence_nan(float32_pack_raw(p), s);
> default:
> p = round_canonical(p, s, &float32_params);
> @@ -539,6 +543,7 @@ static float64 float64_round_pack_canonical(FloatParts p,
> float_status *s)
> case float_class_dnan:
> return float64_default_nan(s);
> case float_class_msnan:
> + p.frac >>= float64_params.frac_shift;
> return float64_maybe_silence_nan(float64_pack_raw(p), s);
> default:
> p = round_canonical(p, s, &float64_params);
--
Alex Bennée
- [Qemu-devel] [PATCH v5 00/28] softfloat patch roundup, Richard Henderson, 2018/05/14
- [Qemu-devel] [PATCH v5 01/28] fpu/softfloat: Fix conversion from uint64 to float128, Richard Henderson, 2018/05/14
- [Qemu-devel] [PATCH v5 02/28] fpu/softfloat: Merge NO_SIGNALING_NANS definitions, Richard Henderson, 2018/05/14
- [Qemu-devel] [PATCH v5 04/28] fpu/softfloat: Move softfloat-specialize.h below FloatParts definition, Richard Henderson, 2018/05/14
- [Qemu-devel] [PATCH v5 03/28] fpu/softfloat: Split floatXX_silence_nan from floatXX_maybe_silence_nan, Richard Henderson, 2018/05/14
- [Qemu-devel] [PATCH v5 05/28] fpu/softfloat: Canonicalize NaN fraction, Richard Henderson, 2018/05/14
- [Qemu-devel] [PATCH v5 06/28] fpu/softfloat: Introduce parts_is_snan_frac, Richard Henderson, 2018/05/14
- [Qemu-devel] [PATCH v5 09/28] target/arm: Use floatX_silence_nan when we have already checked for SNaN, Richard Henderson, 2018/05/14
- [Qemu-devel] [PATCH v5 08/28] fpu/softfloat: Replace float_class_msnan with parts_silence_nan, Richard Henderson, 2018/05/14
- [Qemu-devel] [PATCH v5 07/28] fpu/softfloat: Replace float_class_dnan with parts_default_nan, Richard Henderson, 2018/05/14
- [Qemu-devel] [PATCH v5 11/28] target/arm: squash FZ16 behaviour for conversions, Richard Henderson, 2018/05/14
- [Qemu-devel] [PATCH v5 12/28] target/arm: Remove floatX_maybe_silence_nan from conversions, Richard Henderson, 2018/05/14