[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 21/42] job: Replace BlockJob.completed with job_
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH 21/42] job: Replace BlockJob.completed with job_is_completed() |
Date: |
Mon, 14 May 2018 19:33:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 2018-05-09 18:26, Kevin Wolf wrote:
> Since we introduced an explicit status to block job, BlockJob.completed
> is redundant because it can be derived from the status. Remove the field
> from BlockJob and add a function to derive it from the status at the Job
> level.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> include/block/blockjob.h | 3 ---
> include/qemu/job.h | 3 +++
> blockjob.c | 16 +++++++---------
> job.c | 22 ++++++++++++++++++++++
> qemu-img.c | 4 ++--
> 5 files changed, 34 insertions(+), 14 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH 21/42] job: Replace BlockJob.completed with job_is_completed(), Kevin Wolf, 2018/05/09
[Qemu-devel] [PATCH 23/42] blockjob: Split block_job_event_pending(), Kevin Wolf, 2018/05/09
[Qemu-devel] [PATCH 19/42] job: Add job_sleep_ns(), Kevin Wolf, 2018/05/09
[Qemu-devel] [PATCH 20/42] job: Move pause/resume functions to Job, Kevin Wolf, 2018/05/09