[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] hw/virtio: Fix brace Werror with clang 6.0.
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] hw/virtio: Fix brace Werror with clang 6.0.0 |
|
Date: |
Mon, 14 May 2018 12:44:14 -0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/11/2018 10:48 PM, Richard Henderson wrote:
> The warning is
>
> hw/virtio/vhost-user.c:1319:26: error: suggest braces
> around initialization of subobject [-Werror,-Wmissing-braces]
> VhostUserMsg msg = { 0 };
> ^
> {}
>
> While the original code is correct, and technically exactly correct
> as per ISO C89, both GCC and Clang support plain empty set of braces
> as an extension.
>
> Cc: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/virtio/vhost-user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index 38da8692bb..b455fca394 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -1316,7 +1316,7 @@ static bool vhost_user_requires_shm_log(struct
> vhost_dev *dev)
>
> static int vhost_user_migration_done(struct vhost_dev *dev, char* mac_addr)
> {
> - VhostUserMsg msg = { 0 };
> + VhostUserMsg msg = { };
>
> assert(dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER);
>
>