[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 25/27] fpu/softfloat: Make is_nan et al avail
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 25/27] fpu/softfloat: Make is_nan et al available to softfloat-specialize.h |
Date: |
Mon, 14 May 2018 15:46:10 +0100 |
On 12 May 2018 at 01:43, Richard Henderson <address@hidden> wrote:
> We will need these helpers within softfloat-specialize.h, so move
> the definitions above the include. After specialization, they will
> not always be used so mark them to avoid the Werror.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> fpu/softfloat.c | 30 ++++++++++++++++--------------
> 1 file changed, 16 insertions(+), 14 deletions(-)
>
> diff --git a/fpu/softfloat.c b/fpu/softfloat.c
> index 15a272759d..bafb3b17ec 100644
> --- a/fpu/softfloat.c
> +++ b/fpu/softfloat.c
> @@ -181,6 +181,22 @@ typedef enum __attribute__ ((__packed__)) {
> float_class_snan,
> } FloatClass;
>
> +/* Simple helpers for checking if what NaN we have */
"if/what" (ditto below).
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- Re: [Qemu-devel] [PATCH v2 20/27] target/riscv: Remove floatX_maybe_silence_nan from conversions, (continued)
- [Qemu-devel] [PATCH v2 22/27] fpu/softfloat: Use float*_silence_nan in propagateFloat*NaN, Richard Henderson, 2018/05/11
- [Qemu-devel] [PATCH v2 21/27] target/s390x: Remove floatX_maybe_silence_nan from conversions, Richard Henderson, 2018/05/11
- [Qemu-devel] [PATCH v2 23/27] fpu/softfloat: Remove floatX_maybe_silence_nan, Richard Henderson, 2018/05/11
- [Qemu-devel] [PATCH v2 24/27] fpu/softfloat: Specialize on snan_bit_is_one, Richard Henderson, 2018/05/11
- [Qemu-devel] [PATCH v2 25/27] fpu/softfloat: Make is_nan et al available to softfloat-specialize.h, Richard Henderson, 2018/05/11
- Re: [Qemu-devel] [PATCH v2 25/27] fpu/softfloat: Make is_nan et al available to softfloat-specialize.h,
Peter Maydell <=
- [Qemu-devel] [PATCH v2 26/27] fpu/softfloat: Pass FloatClass to pickNaN, Richard Henderson, 2018/05/11
- [Qemu-devel] [PATCH v2 27/27] fpu/softfloat: Pass FloatClass to pickNaNMulAdd, Richard Henderson, 2018/05/11
- Re: [Qemu-devel] [PATCH v2 00/27] softfloat patch roundup, Peter Maydell, 2018/05/14