Re: [Qemu-devel] [PATCH v2 14/27] target/arm: squash FZ16 behaviour for conversions

[Peter Maydell]

On 12 May 2018 at 01:42, Richard Henderson <address@hidden> wrote:
> From: Alex Bennée <address@hidden>
>
> The ARM ARM specifies FZ16 is suppressed for conversions. Rather than
> pushing this logic into the softfloat code we can simply save the FZ
> state and temporarily disable it for the softfloat call.
>
> Signed-off-by: Alex Bennée <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
>
> ---
> v4
>   - float16_to_floatX squished the wrong softfloat bit for FZ16;
>     need to adjust input denormals in this case.
> ---
>  target/arm/helper.c | 40 ++++++++++++++++++++++++++++++++++++----
>  1 file changed, 36 insertions(+), 4 deletions(-)

Reviewed-by: Peter Maydell <address@hidden>

(once you've fixed up which fp status pointer we pass to these
helpers, then they do the right thing)

thanks
-- PMM