Re: [Qemu-devel] [PATCH] configure: Use strings command from cross development tools

[Philippe Mathieu-Daudé]

On 05/13/2018 05:50 AM, Stefan Weil wrote:
> This fixes cross builds for the (rare) case where cross binutils
> but no native binutils are installed.
> 
> Signed-off-by: Stefan Weil <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  configure | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 24c411e346..4f6ace1ed4 100755
> --- a/configure
> +++ b/configure
> @@ -517,6 +517,7 @@ objcopy="${OBJCOPY-${cross_prefix}objcopy}"
>  ld="${LD-${cross_prefix}ld}"
>  ranlib="${RANLIB-${cross_prefix}ranlib}"
>  nm="${NM-${cross_prefix}nm}"
> +strings="${STRINGS-${cross_prefix}strings}"
>  strip="${STRIP-${cross_prefix}strip}"
>  windres="${WINDRES-${cross_prefix}windres}"
>  pkg_config_exe="${PKG_CONFIG-${cross_prefix}pkg-config}"
> @@ -1956,9 +1957,9 @@ int main(int argc, char *argv[]) {
>  EOF
>  
>  if compile_object ; then
> -    if strings -a $TMPO | grep -q BiGeNdIaN ; then
> +    if "$strings" -a $TMPO | grep -q BiGeNdIaN ; then
>          bigendian="yes"
> -    elif strings -a $TMPO | grep -q LiTtLeEnDiAn ; then
> +    elif "$strings" -a $TMPO | grep -q LiTtLeEnDiAn ; then
>          bigendian="no"
>      else
>          echo big/little test failed
>