Re: [Qemu-devel] [PATCH 0/5] linux-user: move socket.h definitions to CPU directories

[Philippe Mathieu-Daudé]

On 05/10/2018 07:25 PM, Laurent Vivier wrote:
> Splitting out socket.h definitions helps to read the code
> and to fix the bugs...
> 
> No code change, except for the last one that ports
> definitions from linux for sparc as the values are not the
> correct ones.
> 
> Laurent Vivier (5):
>   linux-user: move mips socket.h definitions to mips/sockbits.h
>   linux-user: move alpha socket.h definitions to alpha/sockbits.h
>   linux-user: move sparc/sparc64 socket.h definitions to
>     sparc/sockbits.h
>   linux-user: move ppc socket.h definitions to ppc/sockbits.h

^ patches 1-4:
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

>   linux-user: copy sparc/sockbits.h definitions from linux
> 
>  linux-user/alpha/sockbits.h   | 113 ++++++++++++++++++
>  linux-user/mips/sockbits.h    | 110 ++++++++++++++++++
>  linux-user/mips64/sockbits.h  |   1 +
>  linux-user/ppc/sockbits.h     |  58 ++++++++++
>  linux-user/socket.h           | 261 
> +-----------------------------------------
>  linux-user/sparc/sockbits.h   | 111 ++++++++++++++++++
>  linux-user/sparc64/sockbits.h |   1 +
>  7 files changed, 397 insertions(+), 258 deletions(-)
>  create mode 100644 linux-user/alpha/sockbits.h
>  create mode 100644 linux-user/mips/sockbits.h
>  create mode 100644 linux-user/mips64/sockbits.h
>  create mode 100644 linux-user/ppc/sockbits.h
>  create mode 100644 linux-user/sparc/sockbits.h
>  create mode 100644 linux-user/sparc64/sockbits.h
>