[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/8] checkpatch: ignore email headers better
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL 4/8] checkpatch: ignore email headers better |
Date: |
Sat, 12 May 2018 10:28:20 +0100 |
From: Joe Perches <address@hidden>
There are some patches created by git format-patch that when scanned by
checkpatch report errors on lines like
To: address.tld
This is a checkpatch false positive.
Improve the logic a bit to ignore folded email headers to avoid emitting
these messages.
Signed-off-by: Joe Perches <address@hidden>
Signed-off-by: Andrew Morton <address@hidden>
Signed-off-by: Linus Torvalds <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
Message-id: address@hidden
(cherry picked from commit 29ee1b0c67e0dd7dea8dd718e8326076bce5b6fe)
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
scripts/checkpatch.pl | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 25bf43bad0..20d5b62586 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1183,7 +1183,7 @@ sub process {
my $signoff = 0;
my $is_patch = 0;
- my $in_header_lines = 1;
+ my $in_header_lines = $file ? 0 : 1;
my $in_commit_log = 0; #Scanning lines before patch
my $non_utf8_charset = 0;
@@ -1411,7 +1411,8 @@ sub process {
# Check if it's the start of a commit log
# (not a header line and we haven't seen the patch filename)
if ($in_header_lines && $realfile =~ /^$/ &&
- $rawline !~ /^(commit\b|from\b|\w+:).+$/i) {
+ !($rawline =~ /^\s+\S/ ||
+ $rawline =~ /^(commit\b|from\b|[\w-]+:).*$/i)) {
$in_header_lines = 0;
$in_commit_log = 1;
}
--
2.17.0
- [Qemu-devel] [PULL 0/8] Block patches, Stefan Hajnoczi, 2018/05/12
- [Qemu-devel] [PULL 1/8] blockjob: drop block_job_pause/resume_all(), Stefan Hajnoczi, 2018/05/12
- [Qemu-devel] [PULL 2/8] checkpatch: add a --strict check for utf-8 in commit logs, Stefan Hajnoczi, 2018/05/12
- [Qemu-devel] [PULL 3/8] checkpatch: check utf-8 content from a commit log when it's missing from charset, Stefan Hajnoczi, 2018/05/12
- [Qemu-devel] [PULL 4/8] checkpatch: ignore email headers better,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL 6/8] checkpatch: reduce MAINTAINERS update message frequency, Stefan Hajnoczi, 2018/05/12
- [Qemu-devel] [PULL 5/8] checkpatch: emit a warning on file add/move/delete, Stefan Hajnoczi, 2018/05/12
- [Qemu-devel] [PULL 7/8] block/file-posix: implement bdrv_co_invalidate_cache() on Linux, Stefan Hajnoczi, 2018/05/12
- [Qemu-devel] [PULL 8/8] block/file-posix: add x-check-page-cache=on|off option, Stefan Hajnoczi, 2018/05/12
- Re: [Qemu-devel] [PULL 0/8] Block patches, no-reply, 2018/05/12
- Re: [Qemu-devel] [PULL 0/8] Block patches, Peter Maydell, 2018/05/14
- Re: [Qemu-devel] [PULL 0/8] Block patches, Peter Maydell, 2018/05/14