Re: [Qemu-devel] [PATCH 4/5] linux-user: move ppc socket.h definitions to ppc/sockbits.h

[Peter Maydell]

On 10 May 2018 at 23:26, Laurent Vivier <address@hidden> wrote:
> No code change.
>
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
> --- a/linux-user/socket.h
> +++ b/linux-user/socket.h
> @@ -1,6 +1,6 @@
>
>  #if defined(TARGET_MIPS) || defined(TARGET_HPPA) || defined(TARGET_ALPHA) || 
> \
> -    defined(TARGET_SPARC)
> +    defined(TARGET_SPARC) || defined(TARGET_PPC)
>  #include "sockbits.h"
>  #else

Follow-on cleanup: rather than having this long list of target ifdefs,
we should just have every target supply a sockbits.h (perhaps deferring
to a generic set of values the way that lots of archs use the asm-generic
versions).

thanks
-- PMM