Re: [Qemu-devel] [PATCH v2 2/7] block: Add Error parameter to bdrv_amend_options

[Eric Blake]

On 05/09/2018 04:00 PM, Max Reitz wrote:
> Looking at the qcow2 code that is riddled with error_report() calls,
> this is really how it should have been from the start.
>
> Along the way, turn the target_version/current_version comparisons at
> the beginning of qcow2_downgrade() into assertions (the caller has to
> make sure these conditions are met), and rephrase the error message on
> using compat=1.1 to get refcount widths other than 16 bits.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org