|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [PATCH 0/2] xen-hvm: use new resource mapping API |
Date: | Wed, 9 May 2018 12:26:06 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/09/2018 11:05 AM, Paul Durrant wrote:
xenforeignmemory_map_resource() to map ioreq pages... ERROR: spaces required around that '*' (ctx:WxV) #164: FILE: include/hw/xen/xen_common.h:128: + xenforeignmemory_handle *fmem, domid_t domid, unsigned int type, ^ total: 1 errors, 0 warnings, 138 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS.This style warning appears to be spurious.
Yep, and it's because xenforeignmemory_handle doesn't follow our usual conventions for a type name. See commit 5ac067a if you want to add it to the list of whitelisted exception type names, to silence messages like this.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |