qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 36/67] migration: add include directory headers


From: Juan Quintela
Subject: Re: [Qemu-devel] [PATCH 36/67] migration: add include directory headers
Date: Tue, 08 May 2018 14:25:07 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

"Michael S. Tsirkin" <address@hidden> wrote:
> This way they are easier to find using standard rules.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>

Nack.

This are _internal_ files, that shouldn't be used anywere elese.

Except .... that we need them to write tests.  We only have two scopes
on qemu:
- internal: only for the subsystem we are at in
- pubilc: they can be used everywhere

So, tests came in a strange class here, because they need internal
implementation, but they are not in the proper directory due to the way
we do tests.

I *think* that using complete paths is the only reasonable way of doing
this.

Thanks, Juan.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]