Re: [Qemu-devel] [PATCH 5/5] block/nbd-client: don't check ioc

[Eric Blake]

On 05/07/2018 10:44 AM, Vladimir Sementsov-Ogievskiy wrote:
> We have several paranoiac checks for ioc != NULL. But ioc may become
> NULL only on close, which should not happen during requests handling.
> Also, we check ioc only sometimes, not after each yield, which is
> inconsistent. Let's drop these checks.

Can (or even should) any of these be replaced by asserts that ioc is not 
NULL?

> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
>   block/nbd-client.c | 14 +-------------
>   1 file changed, 1 insertion(+), 13 deletions(-)

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org