[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] softfloat: Handle default NaN mode after pickNa
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] softfloat: Handle default NaN mode after pickNaNMulAdd, not before |
|
Date: |
Mon, 7 May 2018 10:03:30 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/04/2018 03:05 AM, Peter Maydell wrote:
> It is implementation defined whether a multiply-add of
> (0,inf,qnan) or (inf,0,qnan) raises InvalidaOperation or
> not, so we let the target-specific pickNaNMulAdd function
> handle this. This means that we must do the "return the
> default NaN in default NaN mode" check after the call,
> not before. Correct the ordering, and restore the comment
> from the old propagateFloat64MulAddNaN() that warned about
> this corner case.
>
> This fixes a regression from 2.11 for Arm guests where we would
> incorrectly fail to set the Invalid flag for these cases.
>
> Cc: address@hidden
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> fpu/softfloat.c | 52 ++++++++++++++++++++++++++++---------------------
> 1 file changed, 30 insertions(+), 22 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~