qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 4/5] arm: boot: set boot_info starting from f


From: Igor Mammedov
Subject: Re: [Qemu-devel] [PATCH v4 4/5] arm: boot: set boot_info starting from first_cpu
Date: Fri, 4 May 2018 10:05:33 +0200

On Thu, 3 May 2018 16:03:09 +0100
Peter Maydell <address@hidden> wrote:

> On 1 May 2018 at 14:44, Igor Mammedov <address@hidden> wrote:
> > Even though nothing is currently broken (since all boards
> > use first_cpu as boot cpu), make sure that boot_info is set
> > on all CPUs.
> > If some board would like support heterogenuos setup (i.e.
> > init boot_info on subset of CPUs) in future, it should add
> > a reasonable API to do it, instead of starting assigning
> > boot_info from some CPU and till the end of present CPUs
> > list.  
> 
> It's a bit confusing to only send one patch rather than the
> whole set -- our automated patch application and testing
> tooling gets confused. I noticed this one by chance because
> I was skimming the commit log for v3 and noticed that it was
> missing this text. If the change had been in code rather than
> in the commit message I would probably not have picked it up...
I wanted to not to spam too much list with respin of whole series
for commit message fixup, sending fixed up vX as reply is usually
ok for x86 trees but it's up to a maintainer preference.
Next time for fixups, I'll respin whole series if it's intended
to go via ARM tree.

> thanks
> -- PMM




reply via email to

[Prev in Thread] Current Thread [Next in Thread]