[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-arm] [PATCH 4/9] tcg: Introduce atomic helpers fo
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [Qemu-arm] [PATCH 4/9] tcg: Introduce atomic helpers for integer min/max |
|
Date: |
Thu, 3 May 2018 19:19:40 +0100 |
On 3 May 2018 at 18:39, Richard Henderson <address@hidden> wrote:
> On 05/03/2018 10:26 AM, Peter Maydell wrote:
>>> It won't be compiled for the 32-bit host. Translation will not attempt to
>>> use
>>> this helper and will instead call exit_atomic.
>>
>> OK. Can you point me at the code that handles min/max atomics in that case?
>
> exit_atomic raises EXP_ATOMIC, which leads to cpu_exec_step_atomic, which
> grabs
> the exclusive lock and then executes the operation in a serial context. This
> is expanded inline via do_nonatomic_op_i64.
Ah, gotcha -- hidden behind a lot of macros.
Reviewed-by: Peter Maydell <address@hidden>
-- PMM