Re: [Qemu-devel] [PATCH] net: Silence 'has no peer' messages in testing mode

[Markus Armbruster]

Thomas Huth <address@hidden> writes:

> When running qtests with -nodefaults, we are not interested in
> these 'XYZ has no peer' messages.
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>  net/net.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/net/net.c b/net/net.c
> index 29f8398..58bf85e 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -1427,12 +1427,13 @@ void net_check_clients(void)
>  
>      net_hub_check_clients();
>  
> -    QTAILQ_FOREACH(nc, &net_clients, next) {
> -        if (!nc->peer) {
> -            warn_report("%s %s has no peer",
> -                        nc->info->type == NET_CLIENT_DRIVER_NIC
> -                        ? "nic" : "netdev",
> -                        nc->name);
> +    if (!qtest_enabled() || nd_table[0].used) {

I understand the !qtest_enabled part, but not the nd_table[0].used
part.  Can you explain?

> +        QTAILQ_FOREACH(nc, &net_clients, next) {
> +            if (!nc->peer) {
> +                warn_report("%s %s has no peer",
> +                            nc->info->type == NET_CLIENT_DRIVER_NIC
> +                            ? "nic" : "netdev", nc->name);
> +            }
>          }
>      }