[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.13 v3 1/2] slirp: Add "query-usernet" QMP
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH for-2.13 v3 1/2] slirp: Add "query-usernet" QMP command |
|
Date: |
Wed, 2 May 2018 09:44:08 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 02.05.2018 09:29, Fam Zheng wrote:
> On Tue, 05/01 22:41, Samuel Thibault wrote:
>> Hello,
>>
>> I'm sorry I didn't find the time to have a look at it before.
>>
>> In general it looks good, just a few things:
>>
>> Samuel
>>
>> Fam Zheng, le ven. 16 mars 2018 14:28:21 +0800, a ecrit:
>>> + if (!net_hub_id_for_client(&s->nc, &vlan)) {
>>
>> That makes me think that IIUC, we shouldn't call them vlan, as mentioned
>> in the recent vlan->hub renaming patches.
>>
>>> +{ 'struct': 'UsernetInfo',
>>> + 'data': {
>>> + 'id': 'str',
>>> + 'vlan': 'int',
>>
>> and here as well, I guess.
>
> OK, so rename this to hub? (I'm not familiar with the naming issue you pointed
> out).
Yes, please rename it to "hub". See:
https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg05448.html
Thomas