qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 0/5] checkpatch: backport UTF-8 fixes and MAI


From: Thomas Huth
Subject: Re: [Qemu-devel] [PATCH v2 0/5] checkpatch: backport UTF-8 fixes and MAINTAINERS check
Date: Wed, 2 May 2018 07:23:30 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 01.05.2018 15:04, Stefan Hajnoczi wrote:
> On Mon, Apr 30, 2018 at 05:56:30AM -0700, address@hidden wrote:
>> === OUTPUT BEGIN ===
>> Checking PATCH 1/5: checkpatch: add a --strict check for utf-8 in commit 
>> logs...
>> WARNING: line over 80 characters
>> #101: FILE: scripts/checkpatch.pl:1420:
>> +                    WARN("8-bit UTF-8 used in possible commit log\n" . 
>> $herecurr);
>>
>> total: 0 errors, 1 warnings, 66 lines checked
>>
>> Your patch has style problems, please review.  If any of these errors
>> are false positives report them to the maintainer, see
>> CHECKPATCH in MAINTAINERS.
>> Checking PATCH 2/5: checkpatch: check utf-8 content from a commit log when 
>> it's missing from charset...
>> Checking PATCH 3/5: checkpatch: ignore email headers better...
>> Checking PATCH 4/5: checkpatch: emit a warning on file add/move/delete...
>> WARNING: line over 80 characters
>> #46: FILE: scripts/checkpatch.pl:1397:
>> +                 ($line =~ /\{\s*([\w\/\.\-]*)\s*\=\>\s*([\w\/\.\-]*)\s*\}/ 
>> &&
>>
>> ERROR: line over 90 characters
>> #49: FILE: scripts/checkpatch.pl:1400:
>> +                    WARN("added, moved or deleted file(s), does MAINTAINERS 
>> need updating?\n" . $herecurr);
>>
>> total: 1 errors, 1 warnings, 24 lines checked
>>
>> Your patch has style problems, please review.  If any of these errors
>> are false positives report them to the maintainer, see
>> CHECKPATCH in MAINTAINERS.
>>
>> Checking PATCH 5/5: checkpatch: reduce MAINTAINERS update message 
>> frequency...
>> === OUTPUT END ===
> 
> If there are no objections I'd like to keep this in sync with upstream,
> and error messages are exempt from the 80 char limit to aid grepping.

Yes, please keep it as close as possible to upstream. This will also
help to backport future patches from the Linux version to our version
(so we can cherry-pick without conflicts).

 Thomas

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]