Re: [Qemu-devel] [PULL v1 2/2] tests: Add test-listen - a stress test for QEMU socket listen

[Daniel P . Berrangé]

On Tue, May 01, 2018 at 04:21:01PM +0200, Knut Omang wrote:
> On Tue, 2018-05-01 at 15:07 +0100, Daniel P. Berrangé wrote:
> > On Tue, May 01, 2018 at 04:00:35PM +0200, Knut Omang wrote:
> > > Hi Peter,
> > > 
> > > Seems this test was lost along the way?
> > > 
> > > I thought it got merged with Daniel's fix to the potential leak 
> > > that the test exposed in your build, but it seems not?
> > 
> > I've never been able to get this test, nor another one of my own
> > to succesfully pass automated testing in all the various test
> > envs Peter and our many CI systems use.
> 
> Ok, that explains it - no big deal from my side, I just thought 
> it was "value lost" against future errors.
> 
> Would it make sense to let the test check for environment and just 
> really run in cases where it reliably passes?

That's why I've actually been trying to do - I hacked some checks into the
start of the test suite that were supposed to detect if it can run
reliably but it still got failures. Because of the large number of
socketss it opens it was hitting FD resource limits at times IIRC

FWIW, I still have the patch on my local queue and hope one day I'll have
an insight to fix it enough to merge...

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|