[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] m68k: Fix floatx80_lognp1 (Coverity CID1390
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] m68k: Fix floatx80_lognp1 (Coverity CID1390587) |
|
Date: |
Tue, 1 May 2018 00:11:56 -0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/30/2018 02:01 PM, Laurent Vivier wrote:
> return the result of packFloatx80() instead of
> dropping it.
(missed in 4b5c65b8f02).
>
> Signed-off-by: Laurent Vivier <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> target/m68k/softfloat.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/target/m68k/softfloat.c b/target/m68k/softfloat.c
> index dffb371c71..2c069a5efb 100644
> --- a/target/m68k/softfloat.c
> +++ b/target/m68k/softfloat.c
> @@ -334,7 +334,8 @@ floatx80 floatx80_lognp1(floatx80 a, float_status *status)
> if (aSign && aExp >= one_exp) {
> if (aExp == one_exp && aSig == one_sig) {
> float_raise(float_flag_divbyzero, status);
> - packFloatx80(aSign, floatx80_infinity.high,
> floatx80_infinity.low);
> + return packFloatx80(aSign, floatx80_infinity.high,
> + floatx80_infinity.low);
> }
> float_raise(float_flag_invalid, status);
> return floatx80_default_nan(status);
>