[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 13/24] avocado_qemu: Functional test for RHBZ#1431
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RFC 13/24] avocado_qemu: Functional test for RHBZ#1431939 |
Date: |
Mon, 30 Apr 2018 14:02:46 +0100 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Fri, Apr 20, 2018 at 03:19:40PM -0300, Eduardo Habkost wrote:
> + def test_hotplug_memory_default_policy(self):
> + """
> + According to the RHBZ1431939, the issue is 'host nodes'
> + returning '128'. It should return empty value when memory
> + hotplug default policy is used.
> +
> + Fixed in commit d81d857f4421d205395d55200425daa6591c28a5.
> + :avocado: tags=RHBZ1431939
> + """
> +
> + cmd = 'object_add memory-backend-ram,id=mem1,size=1G'
> + res = self.vm.qmp('human-monitor-command', command_line=cmd)
> + self.assertEqual('', res['return'])
General question about QMP test coding style:
What happens if res['return'] does not exist because the QMP command
failed?
I tend to use dict.get() to prevent KeyError. That way the
assertEqual() will fail instead of an unhandled KeyError in the test
code.
Stefan
signature.asc
Description: PGP signature
- [Qemu-devel] [RFC 04/24] avocado_qemu: Be lenient towards poluted serial console, (continued)
- [Qemu-devel] [RFC 04/24] avocado_qemu: Be lenient towards poluted serial console, Eduardo Habkost, 2018/04/20
- [Qemu-devel] [RFC 05/24] avocado_qemu: Increase the login timeout to 60s, Eduardo Habkost, 2018/04/20
- [Qemu-devel] [RFC 06/24] avocado_qemu: Add " " after the default prompt regexp, Eduardo Habkost, 2018/04/20
- [Qemu-devel] [RFC 07/24] avocado_qemu: Store "arch" in VM, Eduardo Habkost, 2018/04/20
- [Qemu-devel] [RFC 08/24] avocado_qemu: Provide defaults for user and pass, Eduardo Habkost, 2018/04/20
- [Qemu-devel] [RFC 09/24] avocado_qemu: Ignore kernel messages on get_console, Eduardo Habkost, 2018/04/20
- [Qemu-devel] [RFC 10/24] avocado_qemu: Add support to request image for testing, Eduardo Habkost, 2018/04/20
- [Qemu-devel] [RFC 11/24] avocado_qemu: Fix exception name in caller, Eduardo Habkost, 2018/04/20
- [Qemu-devel] [RFC 12/24] avocado_qemu: Improve migration error message, Eduardo Habkost, 2018/04/20
- [Qemu-devel] [RFC 13/24] avocado_qemu: Functional test for RHBZ#1431939, Eduardo Habkost, 2018/04/20
- Re: [Qemu-devel] [RFC 13/24] avocado_qemu: Functional test for RHBZ#1431939,
Stefan Hajnoczi <=
- [Qemu-devel] [RFC 14/24] avocado_qemu: Functional test for RHBZ#1447027, Eduardo Habkost, 2018/04/20
- [Qemu-devel] [RFC 15/24] avocado_qemu: Functional test for RHBZ#1436616, Eduardo Habkost, 2018/04/20
- [Qemu-devel] [RFC 16/24] avocado_qemu: Functional test for RHBZ1473203, Eduardo Habkost, 2018/04/20
- [Qemu-devel] [RFC 17/24] avocado_qemu: Remove duplicate PortTracker implementation, Eduardo Habkost, 2018/04/20
- [Qemu-devel] [RFC 19/24] avocado_qemu: Clean unneeded 'pass', Eduardo Habkost, 2018/04/20
- [Qemu-devel] [RFC 18/24] avocado_qemu: Simplify the installation instructions, Eduardo Habkost, 2018/04/20
- [Qemu-devel] [RFC 20/24] avocado_qemu: Set QMP log level to INFO, Eduardo Habkost, 2018/04/20
- [Qemu-devel] [RFC 22/24] avocado_qemu: Tests fixes, Eduardo Habkost, 2018/04/20
- [Qemu-devel] [RFC 21/24] avocado_qemu: Introduce the add_image() VM API, Eduardo Habkost, 2018/04/20