qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC 13/24] avocado_qemu: Functional test for RHBZ#1431


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [RFC 13/24] avocado_qemu: Functional test for RHBZ#1431939
Date: Mon, 30 Apr 2018 14:02:46 +0100
User-agent: Mutt/1.9.2 (2017-12-15)

On Fri, Apr 20, 2018 at 03:19:40PM -0300, Eduardo Habkost wrote:
> +    def test_hotplug_memory_default_policy(self):
> +        """
> +        According to the RHBZ1431939, the issue is 'host nodes'
> +        returning '128'. It should return empty value when memory
> +        hotplug default policy is used.
> +
> +        Fixed in commit d81d857f4421d205395d55200425daa6591c28a5.
> +        :avocado: tags=RHBZ1431939
> +        """
> +
> +        cmd = 'object_add memory-backend-ram,id=mem1,size=1G'
> +        res = self.vm.qmp('human-monitor-command', command_line=cmd)
> +        self.assertEqual('', res['return'])

General question about QMP test coding style:

What happens if res['return'] does not exist because the QMP command
failed?

I tend to use dict.get() to prevent KeyError.  That way the
assertEqual() will fail instead of an unhandled KeyError in the test
code.

Stefan

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]