Re: [Qemu-devel] [RFC PATCH 06/17] migration: introduce icount field for snapshots

[Pavel Dovgalyuk]

> From: Eric Blake [mailto:address@hidden
> On 04/25/2018 07:46 AM, Pavel Dovgalyuk wrote:
> > Saving icount as a parameters of the snapshot allows navigation between
> > them in the execution replay scenario.
> > This information can be used for finding a specific snapshot for rewinding
> > the recorded execution to the specific moment of the time.
> > E.g., 'reverse step' action needs to load the nearest snapshot which is
> > prior to the current moment of time .
> >
> > Signed-off-by: Pavel Dovgalyuk <address@hidden>
> > ---
> >  block/qapi.c             |   11 +++++++----
> >  blockdev.c               |    3 +++
> >  include/block/snapshot.h |    1 +
> >  migration/savevm.c       |    1 +
> >  qapi/block-core.json     |    5 ++++-
> >  qapi/block.json          |    3 ++-
> >  6 files changed, 18 insertions(+), 6 deletions(-)
> 
> Using scripts/git.orderfile may make your patches easier to review, by
> hoisting interfaces above implementation.

Thank you. This script makes the patches look much better.


Pavel Dovgalyuk