[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/13] hw/xtensa/xtfpga.c: Don't create "null" c
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH 05/13] hw/xtensa/xtfpga.c: Don't create "null" chardevs for serial devices |
Date: |
Wed, 25 Apr 2018 16:39:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 20.04.2018 16:52, Peter Maydell wrote:
> Following commit 12051d82f004024, UART devices should handle
> being passed a NULL pointer chardev, so we don't need to
> create "null" backends in board code. Remove the code that
> does this and updates serial_hds[].
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> hw/xtensa/xtfpga.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/hw/xtensa/xtfpga.c b/hw/xtensa/xtfpga.c
> index 70686a2eb1..9db99e1f7e 100644
> --- a/hw/xtensa/xtfpga.c
> +++ b/hw/xtensa/xtfpga.c
> @@ -278,10 +278,6 @@ static void xtfpga_init(const XtfpgaBoardDesc *board,
> MachineState *machine)
> xtensa_get_extint(env, 1), nd_table);
> }
>
> - if (!serial_hds[0]) {
> - serial_hds[0] = qemu_chr_new("serial0", "null");
> - }
> -
> serial_mm_init(system_io, 0x0d050020, 2, xtensa_get_extint(env, 0),
> 115200, serial_hds[0], DEVICE_NATIVE_ENDIAN);
Reviewed-by: Thomas Huth <address@hidden>
- Re: [Qemu-devel] [PATCH 11/13] superio: Don't use MAX_SERIAL_PORTS for serial port limit, (continued)
- [Qemu-devel] [PATCH 13/13] vl.c: new function max_serial_hds(), Peter Maydell, 2018/04/20
- [Qemu-devel] [PATCH 09/13] hw/char/exynos4210_uart.c: Remove unneeded handling of NULL chardev, Peter Maydell, 2018/04/20
- [Qemu-devel] [PATCH 06/13] vl.c: Provide accessor function serial_hd() for serial_hds[] array, Peter Maydell, 2018/04/20
- [Qemu-devel] [PATCH 05/13] hw/xtensa/xtfpga.c: Don't create "null" chardevs for serial devices, Peter Maydell, 2018/04/20
- [Qemu-devel] [PATCH 04/13] hw/mips/mips_malta: Don't create "null" chardevs for serial devices, Peter Maydell, 2018/04/20
- [Qemu-devel] [PATCH 08/13] Remove checks on MAX_SERIAL_PORTS that are just bounds checks, Peter Maydell, 2018/04/20
- [Qemu-devel] [PATCH 03/13] hw/mips/boston.c: Don't create "null" chardevs for serial devices, Peter Maydell, 2018/04/20
- [Qemu-devel] [PATCH 02/13] hw/arm/fsl-imx*: Don't create "null" chardevs for serial devices, Peter Maydell, 2018/04/20