qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/6] block: byte-based AIO read/write


From: John Snow
Subject: Re: [Qemu-devel] [PATCH 0/6] block: byte-based AIO read/write
Date: Tue, 24 Apr 2018 15:13:46 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0


On 04/24/2018 11:02 AM, Eric Blake wrote:
> On 02/15/2018 01:28 PM, Eric Blake wrote:
>> While we would prefer that block drivers use coroutines instead
>> of aio callbacks, it is a fairly easy exercise to prove that
>> all existing drivers with aio callbacks are merely scaling
>> from bytes into sectors and back to bytes.  So, even though I
>> am not set up to completely run (or even compile-test) this
>> full series, it seems pretty straightforward to change the
>> signature to quit playing games with pointless scaling.
>>
>> Note that except for the null-aio driver, I intentionally did
>> NOT try and change the request_alignment from the block layer's
>> default of 512 (it defaults to 1 only for drivers that use
>> coroutines).
>>
>> (And along the way, I got my address@hidden working;
>> thanks to the help I got on IRC)
> 
> ping
> 

One of your replies to patch 3 suggests you were going to send a v2 --
is that not the case? Do you want deeper review of v1 first?

--js



reply via email to

[Prev in Thread] Current Thread [Next in Thread]