[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 for-2.13] pc-bios/s390-ccw: size_t should be
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v2 for-2.13] pc-bios/s390-ccw: size_t should be unsigned |
Date: |
Mon, 23 Apr 2018 12:08:31 +0200 |
On Mon, 16 Apr 2018 09:45:20 +0200
Thomas Huth <address@hidden> wrote:
> "size_t" should be an unsigned type according to the C standard.
> Thus we should also use this convention in the s390-ccw firmware to avoid
> confusion. I checked the sources, and apart from one spot in libc.c, the
> code should all be fine with this change.
>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1753437
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> v2: Use long instead of ssize_t in uitoa()
>
> pc-bios/s390-ccw/libc.c | 2 +-
> pc-bios/s390-ccw/libc.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Cornelia Huck <address@hidden>
I assume you'll queue this one yourself?