Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
13cb1ab379 accel/tcg: convert 4/8 byte access and remove softmmu_template
02c10a2f86 accel/tcg: create store_helper
fac7b8ebfb accel/tcg: create load_helper
f4caf27826 accel/tcg: add DATA_SIZE = 2 to softmmu
58ad314ee4 accel/tcg: new softmmu.c with DATA_SIZE=1
c62cf4ced0 accel/tcg: export some cputlb functions

=== OUTPUT BEGIN ===
Checking PATCH 1/6: accel/tcg: export some cputlb functions...
Checking PATCH 2/6: accel/tcg: new softmmu.c with DATA_SIZE=1...
WARNING: line over 80 characters
#187: FILE: accel/tcg/softmmu.c:131:
+        tlb_addr = env->tlb_table[mmu_idx][index].addr_write & 
~TLB_INVALID_MASK;

total: 0 errors, 1 warnings, 279 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/6: accel/tcg: add DATA_SIZE = 2 to softmmu...
WARNING: line over 80 characters
#239: FILE: accel/tcg/softmmu.c:447:
+        tlb_addr = env->tlb_table[mmu_idx][index].addr_write & 
~TLB_INVALID_MASK;

WARNING: line over 80 characters
#316: FILE: accel/tcg/softmmu.c:524:
+        tlb_addr = env->tlb_table[mmu_idx][index].addr_write & 
~TLB_INVALID_MASK;

total: 0 errors, 2 warnings, 473 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/6: accel/tcg: create load_helper...
WARNING: line over 80 characters
#167: FILE: accel/tcg/softmmu.c:132:
+        res1 = load_helper(env, addr1, size, big_endian, code_read, oi, 
retaddr);

WARNING: line over 80 characters
#168: FILE: accel/tcg/softmmu.c:133:
+        res2 = load_helper(env, addr2, size, big_endian, code_read, oi, 
retaddr);

ERROR: space prohibited between function name and open parenthesis '('
#244: FILE: accel/tcg/softmmu.c:204:
+uint8_t __attribute__((flatten)) helper_ret_ldb_cmmu (CPUArchState *env,

total: 1 errors, 2 warnings, 506 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/6: accel/tcg: create store_helper...
ERROR: space prohibited after that open parenthesis '('
#162: FILE: accel/tcg/softmmu.c:316:
+                wv = bswap16( (uint16_t) val);

ERROR: space required before the open parenthesis '('
#227: FILE: accel/tcg/softmmu.c:368:
+    switch(size) {

total: 2 errors, 0 warnings, 314 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/6: accel/tcg: convert 4/8 byte access and remove 
softmmu_template...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden