Re: [Qemu-devel] [RFC PATCH 0/7] avocado: Add acceptance tests parsing the Linux boot console

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [RFC PATCH 0/7] avocado: Add acceptance tests parsing the 
Linux boot console

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
137b1f8943 avocado: Add tests booting the Malta machine
ec4a19f56b avocado: Add a test parsing Linux kernel booting console
dc618b369b avocado: Add an optional flag 'login' to get_console()
19a3666713 qemu.py: Avoid deprecated tempfile.mktemp()
99bb4ac92b qemu.py: Check console arch is supported before calling mktemp()
163318b813 avocado: Update python scripts to upstream codebase
621512b86b AVOCADO_QEMU: Snapshot commit

=== OUTPUT BEGIN ===
Checking PATCH 1/7: AVOCADO_QEMU: Snapshot commit...
WARNING: line over 80 characters
#412: FILE: tests/avocado/avocado_qemu/test.py:121:
+    :raise QEMULoginProcessTerminatedError: If the client terminates during 
login

WARNING: line over 80 characters
#512: FILE: tests/avocado/avocado_qemu/test.py:221:
+            raise QEMULoginProcessTerminatedError(details.status, 
details.output)

WARNING: line over 80 characters
#789: FILE: tests/avocado/test_info_memdev_host_nodes.py:49:
+        cmd = 'object_add 
memory-backend-ram,id=mem1,host-nodes=0,size=2G,policy=bind'

WARNING: line over 80 characters
#841: FILE: tests/avocado/test_nec-usb-xhci.py:29:
+        self.vm.args.extend(['-device', 
'nec-usb-xhci,id=xhci1,bus=bridge1,addr=0x3'])

ERROR: line over 90 characters
#842: FILE: tests/avocado/test_nec-usb-xhci.py:30:
+        self.vm.args.extend(['-drive', 
'file=%s,format=raw,id=drive_usb,if=none' % usbdevice])

ERROR: line over 90 characters
#843: FILE: tests/avocado/test_nec-usb-xhci.py:31:
+        self.vm.args.extend(['-device', 
'usb-storage,drive=drive_usb,id=device_usb,bus=xhci1.0'])

ERROR: line over 90 characters
#1039: FILE: tests/avocado/test_ovmf_with_240_vcpus.py:22:
+                                         
default='/usr/share/edk2/ovmf/OVMF_CODE.secboot.fd')

WARNING: line over 80 characters
#1041: FILE: tests/avocado/test_ovmf_with_240_vcpus.py:24:
+                                         
default='/usr/share/edk2/ovmf/OVMF_VARS.fd')

total: 3 errors, 5 warnings, 1132 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/7: avocado: Update python scripts to upstream codebase...
Checking PATCH 3/7: qemu.py: Check console arch is supported before calling 
mktemp()...
Checking PATCH 4/7: qemu.py: Avoid deprecated tempfile.mktemp()...
Checking PATCH 5/7: avocado: Add an optional flag 'login' to get_console()...
Checking PATCH 6/7: avocado: Add a test parsing Linux kernel booting console...
ERROR: line over 90 characters
#72: FILE: tests/avocado/test_linux-boot-console.py:53:
+        return 
'http://archive.debian.org/debian/dists/lenny/main/installer-alpha/current/images/cdrom/vmlinuz'

ERROR: line over 90 characters
#81: FILE: tests/avocado/test_linux-boot-console.py:62:
+        self.vm._args.extend(['-chardev', 'socket,id=srm,server,nowait,path=' 
+ self.console_path])

WARNING: line over 80 characters
#95: FILE: tests/avocado/test_linux-boot-console.py:76:
+        console = self.vm.get_console(console_address=self.console_path, 
login=False)

ERROR: line over 90 characters
#97: FILE: tests/avocado/test_linux-boot-console.py:78:
+        bootlog = console.read_until_any_line_matches(["Kernel panic - not 
syncing: VFS: Unable to mount root fs"], timeout=30.0)[1]

total: 3 errors, 1 warnings, 91 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 7/7: avocado: Add tests booting the Malta machine...
WARNING: line over 80 characters
#30: FILE: tests/avocado/test_linux-boot-console.py:99:
+        return 
'http://people.debian.org/~aurel32/qemu/mips/vmlinux-2.6.32-5-4kc-malta'

ERROR: line over 90 characters
#39: FILE: tests/avocado/test_linux-boot-console.py:108:
+        self.vm._args.extend(['-chardev', 
'socket,id=uart0,server,nowait,path=' + self.console_path])

WARNING: line over 80 characters
#51: FILE: tests/avocado/test_linux-boot-console.py:120:
+        console = self.vm.get_console(console_address=self.console_path, 
login=False)

ERROR: line over 90 characters
#53: FILE: tests/avocado/test_linux-boot-console.py:122:
+        bootlog = console.read_until_any_line_matches(["Kernel panic - not 
syncing: VFS: Unable to mount root fs"], timeout=6.0)[1]

WARNING: line over 80 characters
#67: FILE: tests/avocado/test_linux-boot-console.py:136:
+# FIXME this is a copy of TestMips4kcMaltaBoot2_6 with a different the kernel 
url

WARNING: line over 80 characters
#76: FILE: tests/avocado/test_linux-boot-console.py:145:
+        return 
'http://people.debian.org/~aurel32/qemu/mips/vmlinux-3.2.0-4-4kc-malta'

ERROR: line over 90 characters
#85: FILE: tests/avocado/test_linux-boot-console.py:154:
+        self.vm._args.extend(['-chardev', 
'socket,id=uart0,server,nowait,path=' + self.console_path])

WARNING: line over 80 characters
#97: FILE: tests/avocado/test_linux-boot-console.py:166:
+        console = self.vm.get_console(console_address=self.console_path, 
login=False)

ERROR: line over 90 characters
#99: FILE: tests/avocado/test_linux-boot-console.py:168:
+        bootlog = console.read_until_any_line_matches(["Kernel panic - not 
syncing: VFS: Unable to mount root fs"], timeout=6.0)[1]

total: 4 errors, 5 warnings, 100 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden