[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] spapr: Support ibm, dynamic-memory-v2 proper
|
From: |
Bharata B Rao |
|
Subject: |
Re: [Qemu-devel] [PATCH v3] spapr: Support ibm, dynamic-memory-v2 property |
|
Date: |
Tue, 17 Apr 2018 14:39:09 +0530 |
|
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Tue, Apr 17, 2018 at 11:14:27AM +1000, David Gibson wrote:
> > static void spapr_machine_2_12_class_options(MachineClass *mc)
> > diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h
> > index d60b7c6d7a..5e044c44af 100644
> > --- a/include/hw/ppc/spapr.h
> > +++ b/include/hw/ppc/spapr.h
> > @@ -149,6 +149,7 @@ struct sPAPRMachineState {
> > sPAPROptionVector *ov5; /* QEMU-supported option vectors */
> > sPAPROptionVector *ov5_cas; /* negotiated (via CAS) option vectors
> > */
> > uint32_t max_compat_pvr;
> > + bool use_ibm_dynamic_memory_v2;
>
> TBH, I'm not really sure we even need to adjust this by machine type.
There are other similar features controlled by ov5 bits that
are also determined by machine type version:
Memory hotplug support -- sPAPRMachineClass.dr_lmb_enabled
Dedicated HP event support -- sPAPRMachineState.use_hotplug_event_source
Are you saying that presence of ibm,dynamic-memory-v2 probably shouldn't
be dependent on machine type ?
Regards,
Bharata.