[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [ARM/FDPIC 1/4] linux-user: ARM-FDPIC: Add configure op
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [ARM/FDPIC 1/4] linux-user: ARM-FDPIC: Add configure option to support loading of FDPIC binaries |
Date: |
Mon, 16 Apr 2018 10:19:50 +0100 |
On 16 April 2018 at 08:57, Christophe Lyon <address@hidden> wrote:
> On 13/04/2018 17:04, Peter Maydell wrote:
>> I think we should just have support for these binaries enabled
>> always. Otherwise it will bitrot because nobody compiles it.
>>
> We are relying on a pre-existing CONFIG_USE_FDPIC, which is currently
> never defined. This was introduced by commit 1af02e83 back in 2011,
> and indeed if you try to build QEMU with CONFIG_USE_FDPIC, the build fails
> because elf_is_fdpic() is not defined.
This looks like an excellent demonstration of why we shouldn't
hide this feature behind a defaults-to-off #define :-)
> Do you suggest removing CONFIG_USE_FDPIC?
Yes. Given how old the existing disabled FDPIC code is, I would also
suggest you carefully review any of it that you're using...
thanks
-- PMM
- [Qemu-devel] [ARM/FDPIC 0/4] FDPIC ABI for ARM, Christophe Lyon, 2018/04/06
- [Qemu-devel] [ARM/FDPIC 2/4] linux-user: ARM-FDPIC: Add support of FDPIC for ARM., Christophe Lyon, 2018/04/06
- [Qemu-devel] [ARM/FDPIC 3/4] linux-user: ARM-FDPIC: Add support for signals for FDPIC targets, Christophe Lyon, 2018/04/06
- [Qemu-devel] [ARM/FDPIC 4/4] linux-user: ARM-FDPIC: Add arm get tls syscall support, Christophe Lyon, 2018/04/06
- Re: [Qemu-devel] [ARM/FDPIC 0/4] FDPIC ABI for ARM, Peter Maydell, 2018/04/13