[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 4/8] migration: Create socket-address paramet
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH v7 4/8] migration: Create socket-address parameter |
Date: |
Fri, 13 Apr 2018 13:02:34 +0100 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Thu, Apr 12, 2018 at 02:09:33PM +0100, Dr. David Alan Gilbert wrote:
> * Juan Quintela (address@hidden) wrote:
> > It will be used to store the uri parameters. We want this only for
> > tcp, so we don't set it for other uris. We need it to know what port
> > is migration running.
> >
> > Signed-off-by: Juan Quintela <address@hidden>
> >
> > --
> >
> > This used to be uri parameter, but it has so many troubles to
> > reproduce that it don't just make sense.
> >
> > This used to be a port parameter. I was asked to move to
> > SocketAddress, done.
> > I also merged the setting of the migration tcp port in this one
> > because now I need to free the address, and this makes it easier.
> > This used to be x-socket-address with a single direction, now it is a
> > list of addresses.
>
> Is there a reason it's a parameter rather than just an entry in
> MigrationInfo?
I imagine it is a side-effect of earlier versions of this patch
which used the migration parameter setter method. Having it in
the MigrationInfo does seem reasonable to me since this is not
a tunable parameter.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH v7 0/8] Add make check tests for Migration, Juan Quintela, 2018/04/04
- [Qemu-devel] [PATCH v7 1/8] qemu-sockets: Export SocketAddress_to_str, Juan Quintela, 2018/04/04
- [Qemu-devel] [PATCH v7 3/8] tests: Add migration xbzrle test, Juan Quintela, 2018/04/04
- [Qemu-devel] [PATCH v7 2/8] tests: Add migration precopy test, Juan Quintela, 2018/04/04
- [Qemu-devel] [PATCH v7 4/8] migration: Create socket-address parameter, Juan Quintela, 2018/04/04
- [Qemu-devel] [PATCH v7 5/8] tests: Migration ppc now inlines its program, Juan Quintela, 2018/04/04
- [Qemu-devel] [PATCH v7 6/8] tests: Add basic migration precopy tcp test, Juan Quintela, 2018/04/04
- [Qemu-devel] [PATCH v7 7/8] migration: Add multifd test, Juan Quintela, 2018/04/04
- [Qemu-devel] [PATCH v7 8/8] [RFH] tests: Add migration compress threads tests, Juan Quintela, 2018/04/04