[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: calculate expected_downtime with ram
From: |
Balamuruhan S |
Subject: |
Re: [Qemu-devel] [PATCH] migration: calculate expected_downtime with ram_bytes_remaining() |
Date: |
Tue, 10 Apr 2018 15:22:33 +0530 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Wed, Apr 04, 2018 at 11:04:59AM +0200, Juan Quintela wrote:
> Balamuruhan S <address@hidden> wrote:
> > expected_downtime value is not accurate with dirty_pages_rate * page_size,
> > using ram_bytes_remaining would yeild it correct.
> >
> > Signed-off-by: Balamuruhan S <address@hidden>
>
> Reviewed-by: Juan Quintela <address@hidden>
>
> See my other mail on the thread, my understanding is that your change is
> corret (TM).
Juan, Please help to merge it.
Regards,
Bala
>
> Thanks, Juan.
>
> > ---
> > migration/migration.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/migration/migration.c b/migration/migration.c
> > index 58bd382730..4e43dc4f92 100644
> > --- a/migration/migration.c
> > +++ b/migration/migration.c
> > @@ -2245,8 +2245,7 @@ static void migration_update_counters(MigrationState
> > *s,
> > * recalculate. 10000 is a small enough number for our purposes
> > */
> > if (ram_counters.dirty_pages_rate && transferred > 10000) {
> > - s->expected_downtime = ram_counters.dirty_pages_rate *
> > - qemu_target_page_size() / bandwidth;
> > + s->expected_downtime = ram_bytes_remaining() / bandwidth;
> > }
> >
> > qemu_file_reset_rate_limit(s->to_dst_file);
>
- [Qemu-devel] [PATCH] migration: calculate expected_downtime with ram_bytes_remaining(), Balamuruhan S, 2018/04/01
- Re: [Qemu-devel] [PATCH] migration: calculate expected_downtime with ram_bytes_remaining(), Balamuruhan S, 2018/04/04
- Re: [Qemu-devel] [PATCH] migration: calculate expected_downtime with ram_bytes_remaining(), Peter Xu, 2018/04/04
- Re: [Qemu-devel] [PATCH] migration: calculate expected_downtime with ram_bytes_remaining(), Balamuruhan S, 2018/04/04
- Re: [Qemu-devel] [PATCH] migration: calculate expected_downtime with ram_bytes_remaining(), Dr. David Alan Gilbert, 2018/04/09
- Re: [Qemu-devel] [PATCH] migration: calculate expected_downtime with ram_bytes_remaining(), David Gibson, 2018/04/09
- Re: [Qemu-devel] [PATCH] migration: calculate expected_downtime with ram_bytes_remaining(), Dr. David Alan Gilbert, 2018/04/10
- Re: [Qemu-devel] [PATCH] migration: calculate expected_downtime with ram_bytes_remaining(), David Gibson, 2018/04/10