[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] virtio-serial: fix heap-over-flow
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] virtio-serial: fix heap-over-flow |
|
Date: |
Wed, 4 Apr 2018 17:22:07 +0300 |
On Wed, Apr 04, 2018 at 10:53:22AM +0100, Stefan Hajnoczi wrote:
> On Wed, Mar 28, 2018 at 09:34:35PM +0800, linzhecheng wrote:
> > Check device having the feature of VIRTIO_CONSOLE_F_EMERG_WRITE before
> > get config->emerg_wr. It is neccessary because sizeof(virtio_console_config)
> > is 8 byte if VirtIOSerial doesn't have the feature of
> > VIRTIO_CONSOLE_F_EMERG_WRITE(see virtio_serial_device_realize),
> > read/write emerg_wr will lead to heap-over-flow.
> >
> > Signed-off-by: linzhecheng <address@hidden>
>
> Michael or Paolo: Please merge for QEMU 2.12
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Will merge.