qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/3] archive-source.sh: Drop submodule code


From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH 1/3] archive-source.sh: Drop submodule code
Date: Wed, 4 Apr 2018 17:07:56 +0800
User-agent: Mutt/1.9.2 (2017-12-15)

On Wed, 04/04 09:23, Daniel P. Berrangé wrote:
> On Wed, Apr 04, 2018 at 10:51:59AM +0800, Fam Zheng wrote:
> > ./configure and make now take care of submodules, we only need to clone
> > the top tree.
> 
> If you don't include the submodules in the tar.gz archive, then the
> test system needs to be able to clone them from qemu.org, which
> requires networking.
> 
> The VM tests have networking by default, but the docker tests do
> not have networking - you need to opt-in by setting NETWORK=1
> make variable. So AFAICT, this will break docker tests.

Yes, I'll revise the patch.

Fam



reply via email to

[Prev in Thread] Current Thread [Next in Thread]