[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC 14/18] qemu.py: Don't try to quit cleanly on exception
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [RFC 14/18] qemu.py: Don't try to quit cleanly on exceptions |
Date: |
Thu, 29 Mar 2018 18:38:53 -0300 |
Exceptions when starting a VM probably mean QEMU exited and the
monitor won't work. It's better to simply terminate the process
instead of trying to communicate using QMP.
Signed-off-by: Eduardo Habkost <address@hidden>
---
scripts/qemu.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index 045dca5d02..00b44ea0f4 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -251,7 +251,7 @@ class QEMUMachine(object):
self._launch()
self._launched = True
except:
- self.shutdown()
+ self.shutdown(force=True)
LOG.debug('Error launching VM')
if self._qemu_full_args:
--
2.14.3
- [Qemu-devel] [RFC 04/18] qemu.py: Make _vm_monitor a method, (continued)
- [Qemu-devel] [RFC 04/18] qemu.py: Make _vm_monitor a method, Eduardo Habkost, 2018/03/29
- [Qemu-devel] [RFC 05/18] qemu.py: Split _base_args(), Eduardo Habkost, 2018/03/29
- [Qemu-devel] [RFC 06/18] qemu.py: Move _load_io_log() call to _post_shutdown(), Eduardo Habkost, 2018/03/29
- [Qemu-devel] [RFC 07/18] qemu.py: Use wait() logic inside shutdown(), Eduardo Habkost, 2018/03/29
- [Qemu-devel] [RFC 08/18] qemu.py: Close _qmp inside _post_shutdown(), Eduardo Habkost, 2018/03/29
- [Qemu-devel] [RFC 09/18] qemu.py: Make monitor optional, Eduardo Habkost, 2018/03/29
- [Qemu-devel] [RFC 10/18] qemu.py: Set _launched = False on _post_shutdown, Eduardo Habkost, 2018/03/29
- [Qemu-devel] [RFC 11/18] qemu.py: Log crashes inside _post_shutdown(), Eduardo Habkost, 2018/03/29
- [Qemu-devel] [RFC 13/18] qemu.py: 'force' parameter on shutdown(), Eduardo Habkost, 2018/03/29
- [Qemu-devel] [RFC 12/18] qemu.py: Only wait for process if it's still running, Eduardo Habkost, 2018/03/29
- [Qemu-devel] [RFC 14/18] qemu.py: Don't try to quit cleanly on exceptions,
Eduardo Habkost <=
- [Qemu-devel] [RFC 15/18] qemu.py: qmp_obj() method, Eduardo Habkost, 2018/03/29
- [Qemu-devel] [RFC 16/18] qemu.py: is_launched() method, Eduardo Habkost, 2018/03/29
- [Qemu-devel] [RFC 17/18] validator.py script, Eduardo Habkost, 2018/03/29
- [Qemu-devel] [RFC 18/18] Collection of validator.py test cases, Eduardo Habkost, 2018/03/29
- Re: [Qemu-devel] [RFC 00/18] QEMU validator: A method to specify QEMU crash-test cases, no-reply, 2018/03/30
- Re: [Qemu-devel] [RFC 00/18] QEMU validator: A method to specify QEMU crash-test cases, no-reply, 2018/03/31