Re: [Qemu-devel] [PATCH 1/4] tpm: CRB: set the Idle flag by default

[Marc-André Lureau]

On Wed, Mar 28, 2018 at 10:59 PM, Stefan Berger
<address@hidden> wrote:
> Signed-off-by: Stefan Berger <address@hidden>
> ---

This is also the default state according to the spec.
Reviewed-by: Marc-André Lureau <address@hidden>


>  hw/tpm/tpm_crb.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c
> index ef8b80e..e728b55 100644
> --- a/hw/tpm/tpm_crb.c
> +++ b/hw/tpm/tpm_crb.c
> @@ -220,6 +220,8 @@ static void tpm_crb_reset(void *dev)
>
>      ARRAY_FIELD_DP32(s->regs, CRB_LOC_STATE,
>                       tpmRegValidSts, 1);
> +    ARRAY_FIELD_DP32(s->regs, CRB_CTRL_STS,
> +                     tpmIdle, 1);
>      ARRAY_FIELD_DP32(s->regs, CRB_INTF_ID,
>                       InterfaceType, CRB_INTF_TYPE_CRB_ACTIVE);
>      ARRAY_FIELD_DP32(s->regs, CRB_INTF_ID,
> --
> 2.5.5
>
>



-- 
Marc-André Lureau