qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] file-posix: Support fallocate for block device


From: no-reply
Subject: Re: [Qemu-devel] [PATCH] file-posix: Support fallocate for block device
Date: Thu, 29 Mar 2018 03:09:44 -0700 (PDT)

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH] file-posix: Support fallocate for block device

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
c955c08515 file-posix: Support fallocate for block device

=== OUTPUT BEGIN ===
Checking PATCH 1/1: file-posix: Support fallocate for block device...
ERROR: braces {} are necessary for all arms of this statement
#66: FILE: block/file-posix.c:1385:
+        if (ret == 0) {
[...]
-        }
[...]

ERROR: braces {} are necessary for all arms of this statement
#70: FILE: block/file-posix.c:1387:
+        } else if (ret == -ENOTSUP)
[...]

total: 2 errors, 0 warnings, 57 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]