[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hmp.c: Revert hmp_info_cpus output format
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH] hmp.c: Revert hmp_info_cpus output format |
Date: |
Tue, 27 Mar 2018 15:04:41 +0100 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
* Eric Blake (address@hidden) wrote:
> [adding the maintainer in cc]
>
> On 03/27/2018 07:38 AM, address@hidden wrote:
> > From: Satheesh Rajendran <address@hidden>
> >
> > This commit 137b5cb6ab565cb3781d5337591e155932b4230e
> > refactors info cpus output and changes output format from
> > 'thread_id' to 'thread-id', this would break parsing
> > of output in above layers like libvirt, test framework etc.
> >
> > This patch just reverts back output format to 'thread_id'.
> >
> > CC: Viktor Mihajlovski <address@hidden>
> > Signed-off-by: Satheesh Rajendran <address@hidden>
> > ---
> > hmp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I can take this through my qapi tree if David is happy with it
Yes, with the commit message change you suggested.
Acked-by: Dr. David Alan Gilbert <address@hidden>
>
> >
> > diff --git a/hmp.c b/hmp.c
> > index 679467d85a..a25c7bd9a8 100644
> > --- a/hmp.c
> > +++ b/hmp.c
> > @@ -381,7 +381,7 @@ void hmp_info_cpus(Monitor *mon, const QDict *qdict)
> > monitor_printf(mon, "%c CPU #%" PRId64 ":", active,
> > cpu->value->cpu_index);
> > - monitor_printf(mon, " thread-id=%" PRId64 "\n",
> > cpu->value->thread_id);
> > + monitor_printf(mon, " thread_id=%" PRId64 "\n",
> > cpu->value->thread_id);
> > }
> > qapi_free_CpuInfoFastList(cpu_list);
> >
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3266
> Virtualization: qemu.org | libvirt.org
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK