[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 06/19] include/block/block_int: Document protocol rel
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PULL 06/19] include/block/block_int: Document protocol related functions |
Date: |
Mon, 26 Mar 2018 16:35:47 +0200 |
From: Fabiano Rosas <address@hidden>
Clarify that:
- for protocols the brdv_file_open function is used instead
of bdrv_open;
- when protocol_name is set, a driver should expect
to be given only a filename and no other options.
Signed-off-by: Fabiano Rosas <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
include/block/block_int.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/include/block/block_int.h b/include/block/block_int.h
index 27e17addba..c4dd1d4bb8 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -126,6 +126,8 @@ struct BlockDriver {
int (*bdrv_open)(BlockDriverState *bs, QDict *options, int flags,
Error **errp);
+
+ /* Protocol drivers should implement this instead of bdrv_open */
int (*bdrv_file_open)(BlockDriverState *bs, QDict *options, int flags,
Error **errp);
void (*bdrv_close)(BlockDriverState *bs);
@@ -251,6 +253,12 @@ struct BlockDriver {
*/
int coroutine_fn (*bdrv_co_flush_to_os)(BlockDriverState *bs);
+ /*
+ * Drivers setting this field must be able to work with just a plain
+ * filename with '<protocol_name>:' as a prefix, and no other options.
+ * Options may be extracted from the filename by implementing
+ * bdrv_parse_filename.
+ */
const char *protocol_name;
int (*bdrv_truncate)(BlockDriverState *bs, int64_t offset,
PreallocMode prealloc, Error **errp);
--
2.13.6
- [Qemu-devel] [PULL 00/19] Block layer patches, Kevin Wolf, 2018/03/26
- [Qemu-devel] [PULL 03/19] block/quorum: Remove protocol-related fields, Kevin Wolf, 2018/03/26
- [Qemu-devel] [PULL 05/19] block/blkreplay: Remove protocol-related fields, Kevin Wolf, 2018/03/26
- [Qemu-devel] [PULL 01/19] iotests: 163 is not quick, Kevin Wolf, 2018/03/26
- [Qemu-devel] [PULL 06/19] include/block/block_int: Document protocol related functions,
Kevin Wolf <=
- [Qemu-devel] [PULL 02/19] block/replication: Remove protocol_name field, Kevin Wolf, 2018/03/26
- [Qemu-devel] [PULL 04/19] block/throttle: Remove protocol-related fields, Kevin Wolf, 2018/03/26
- [Qemu-devel] [PULL 09/19] vdi: Fix build with CONFIG_VDI_DEBUG, Kevin Wolf, 2018/03/26
- [Qemu-devel] [PULL 11/19] qemu-iotests: Enable 025 for luks, Kevin Wolf, 2018/03/26
- [Qemu-devel] [PULL 08/19] vdi: Change 'static' create option to 'preallocation' in QMP, Kevin Wolf, 2018/03/26
- [Qemu-devel] [PULL 13/19] qemu-iotests: Test invalid resize on luks, Kevin Wolf, 2018/03/26
- [Qemu-devel] [PULL 10/19] qemu-iotests: Test vdi image creation with QMP, Kevin Wolf, 2018/03/26
- [Qemu-devel] [PULL 14/19] parallels: Check maximum cluster size on create, Kevin Wolf, 2018/03/26
- [Qemu-devel] [PULL 12/19] luks: Turn another invalid assertion into check, Kevin Wolf, 2018/03/26
- [Qemu-devel] [PULL 16/19] vhdx: Require power-of-two block size on create, Kevin Wolf, 2018/03/26