Re: [Qemu-devel] [PATCH 0/3] RFC: simplify qobject refcount

[Marc-André Lureau]

Hi

On Wed, Mar 21, 2018 at 3:09 PM, Eric Blake <address@hidden> wrote:
> On 03/21/2018 08:40 AM, Marc-André Lureau wrote:
>>
>> Hi,
>>
>> This series aims to get rid of the distinction between QObject, that
>> must use qobject_incref/qobject_decref and its various derived types
>> that have to use QINCREF/QDECREF. Instead, replace it with
>> qobject_ref/qobject_unref for all types.
>
>
> I _like_ the fact that you don't have to use a different thing for the base
> class compared to the derived classes.  I'm not sure I like that the name
> got longer in the QINCREF -> qobject_ref direction, but it got shorter in
> the qobject_incref => qobject_ref direction, so maybe bikeshedding on the
> final name is still possible?

sure :) Tbh, I'd rather keep the qobject prefix for clarity, but we
could also go for qref/qunref ?

>
>>
>> Marc-André Lureau (3):
>>    compiler: extend QEMU_GENERIC to handle more arguments
>>    qobject: assume base of a qobject is at offset 0
>>    qobject: replace qobject_incref/QINCREF qobject_decref/QDECREF
>
>
> But I definitely think this is 2.13 material.  It is easy to do (mechanical
> conversion in 3/3) but a conflict magnet, so it would need to land early
> after the freeze is lifted.

Fortunately, it's a straightforward sed replacement.

thanks