[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.12 09/12] vhdx: Require power-of-two block
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [PATCH for-2.12 09/12] vhdx: Require power-of-two block size on create |
Date: |
Wed, 21 Mar 2018 09:03:16 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Tue, Mar 20, 2018 at 06:36:29PM +0100, Kevin Wolf wrote:
> Images with a non-power-of-two block size are invalid and cannot be
> opened. Reject such block sizes when creating an image.
>
Good catch.
Reviewed-by: Jeff Cody <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/vhdx.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/block/vhdx.c b/block/vhdx.c
> index f1b97f4b49..ca211a3196 100644
> --- a/block/vhdx.c
> +++ b/block/vhdx.c
> @@ -1877,6 +1877,10 @@ static int coroutine_fn
> vhdx_co_create(BlockdevCreateOptions *opts,
> error_setg_errno(errp, EINVAL, "Block size must be a multiple of 1
> MB");
> return -EINVAL;
> }
> + if (!is_power_of_2(block_size)) {
> + error_setg(errp, "Block size must be a power of two");
> + return -EINVAL;
> + }
> if (block_size > VHDX_BLOCK_SIZE_MAX) {
> error_setg_errno(errp, EINVAL, "Block size must not exceed %d",
> VHDX_BLOCK_SIZE_MAX);
> --
> 2.13.6
>
- Re: [Qemu-devel] [PATCH for-2.12 06/12] qemu-iotests: Test invalid resize on luks, (continued)
- [Qemu-devel] [PATCH for-2.12 05/12] luks: Turn another invalid assertion into check, Kevin Wolf, 2018/03/20
- [Qemu-devel] [PATCH for-2.12 03/12] qemu-iotests: Test vdi image creation with QMP, Kevin Wolf, 2018/03/20
- [Qemu-devel] [PATCH for-2.12 07/12] parallels: Check maximum cluster size on create, Kevin Wolf, 2018/03/20
- [Qemu-devel] [PATCH for-2.12 09/12] vhdx: Require power-of-two block size on create, Kevin Wolf, 2018/03/20
- [Qemu-devel] [PATCH for-2.12 08/12] qemu-iotests: Test parallels image creation with QMP, Kevin Wolf, 2018/03/20
- [Qemu-devel] [PATCH for-2.12 10/12] vhdx: Don't use error_setg_errno() with constant errno, Kevin Wolf, 2018/03/20
- [Qemu-devel] [PATCH for-2.12 11/12] vhdx: Check for 4 GB maximum log size on creation, Kevin Wolf, 2018/03/20
- [Qemu-devel] [PATCH for-2.12 12/12] qemu-iotests: Test vhdx image creation with QMP, Kevin Wolf, 2018/03/20