Re: [Qemu-devel] [PATCH 1/1] s390x/cpumodel: fix feature groups and breakage of MSA8

[Michael Mueller]

I could imagine something like this, see attachment.

Michael

On 20.03.18 14:17, Christian Borntraeger wrote:
> David, Jason, Michael,
>
> the cpumodel code is somewhat fragile as we have to add maintain things
> in multiple places. I would like to have more robust code, e.g. by either
> generating more or by having build bug_ons or something like that.
> Any idea is highly welcome.
>
> Christian
>
>
> On 03/20/2018 02:07 PM, Christian Borntraeger wrote:
> > Since commit 46a99c9f73c7 ("s390x/cpumodel: model PTFF subfunctions
> > for Multiple-epoch facility") -cpu help no longer shows the MSA8
> > feature group. Turns out that we forgot to add the new MEPOCH_PTFF
> > group enum.
> >
> > Fixes: 46a99c9f73c7 ("s390x/cpumodel: model PTFF subfunctions for Multiple-epoch 
> > facility")
> > Signed-off-by: Christian Borntraeger <address@hidden>
> > ---
> >   target/s390x/cpu_features.h | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/target/s390x/cpu_features.h b/target/s390x/cpu_features.h
> > index e306aa7ab2..968b12fdfe 100644
> > --- a/target/s390x/cpu_features.h
> > +++ b/target/s390x/cpu_features.h
> > @@ -78,6 +78,7 @@ typedef enum {
> >       S390_FEAT_GROUP_MSA_EXT_6,
> >       S390_FEAT_GROUP_MSA_EXT_7,
> >       S390_FEAT_GROUP_MSA_EXT_8,
> > +    S390_FEAT_GROUP_MULTIPLE_EPOCH_PTFF,
> >       S390_FEAT_GROUP_MAX,
> >   } S390FeatGroup;

0001-target-s390x-enum-type-S390FeatGroup-now-gets-genera.patch
Description: Text document