|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [PULL 18/41] blockjobs: add block-job-finalize |
Date: | Tue, 13 Mar 2018 13:47:53 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 03/13/2018 11:17 AM, Kevin Wolf wrote:
From: John Snow <address@hidden> Instead of automatically transitioning from PENDING to CONCLUDED, gate the .prepare() and .commit() phases behind an explicit acknowledgement provided by the QMP monitor if auto_finalize = false has been requested.
## +# @block-job-finalize: +# +# Once a job that has manual=true reaches the pending state, it can be
Is this wording stale, given that you add two separate auto-* bool flags in 19/41? You may want to prepare a followup patch (doc bug fixes are safe during softfreeze, so it need not hold up this pull request) that tweaks this and any similar stale wording.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |