[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 1/9] char: don't silently skip tn3270 protocol ini
From: |
Daniel P . Berrangé |
Subject: |
[Qemu-devel] [PULL v2 1/9] char: don't silently skip tn3270 protocol init when TLS is enabled |
Date: |
Tue, 13 Mar 2018 18:12:40 +0000 |
From: "Daniel P. Berrange" <address@hidden>
Even if common tn3270 implementations do not support TLS, it is trivial to
have them proxied over a proxy like stunnel which adds TLS at the sockets
layer. We should thus not silently skip tn3270 protocol initialization
when TLS is enabled.
Reviewed-by: Eric Blake <address@hidden>
Acked-by: Cornelia Huck <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>
---
chardev/char-socket.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index a220803c01..1a371b91ac 100644
--- a/chardev/char-socket.c
+++ b/chardev/char-socket.c
@@ -663,8 +663,7 @@ static void tcp_chr_tls_handshake(QIOTask *task,
if (qio_task_propagate_error(task, NULL)) {
tcp_chr_disconnect(chr);
} else {
- /* tn3270 does not support TLS yet */
- if (s->do_telnetopt && !s->is_tn3270) {
+ if (s->do_telnetopt) {
tcp_chr_telnet_init(chr);
} else {
tcp_chr_connect(chr);
--
2.14.3
- [Qemu-devel] [PULL v2 0/9] Socket next patches, Daniel P . Berrangé, 2018/03/13
- [Qemu-devel] [PULL v2 1/9] char: don't silently skip tn3270 protocol init when TLS is enabled,
Daniel P . Berrangé <=
- [Qemu-devel] [PULL v2 2/9] cutils: add qemu_strtoi & qemu_strtoui parsers for int/unsigned int types, Daniel P . Berrangé, 2018/03/13
- [Qemu-devel] [PULL v2 3/9] sockets: pull code for testing IP availability out of specific test, Daniel P . Berrangé, 2018/03/13
- [Qemu-devel] [PULL v2 4/9] sockets: strengthen test suite IP protocol availability checks, Daniel P . Berrangé, 2018/03/13
- [Qemu-devel] [PULL v2 5/9] sockets: move fd_is_socket() into common sockets code, Daniel P . Berrangé, 2018/03/13
- [Qemu-devel] [PULL v2 7/9] sockets: allow SocketAddress 'fd' to reference numeric file descriptors, Daniel P . Berrangé, 2018/03/13
- [Qemu-devel] [PULL v2 8/9] char: refactor parsing of socket address information, Daniel P . Berrangé, 2018/03/13
- [Qemu-devel] [PULL v2 6/9] sockets: check that the named file descriptor is a socket, Daniel P . Berrangé, 2018/03/13
- [Qemu-devel] [PULL v2 9/9] char: allow passing pre-opened socket file descriptor at startup, Daniel P . Berrangé, 2018/03/13
- Re: [Qemu-devel] [PULL v2 0/9] Socket next patches, no-reply, 2018/03/13
- Re: [Qemu-devel] [PULL v2 0/9] Socket next patches, Peter Maydell, 2018/03/16