Re: [Qemu-devel] [PATCH] tests: make address@hidden run sanitizers

[Marc-André Lureau]

Hi Fam,

It would be great if patchew could run the debug/sanitizer build.
Unfortunately, except x86 target, the run is full of ASAN leaks or
warnings.

Do you think patchew could learn to do regression testing? By that I
mean that patchew could compare a patchset output with the current
master (that output should be cached for multiple tests). The output
to compare here would be the errors reported by ASAN during the build.
(eventually, this could be used for other metrics some day). If so,
would you be willing to help me implementing it?


On Mon, Mar 12, 2018 at 1:08 PM, Marc-André Lureau
<address@hidden> wrote:
> Since --enable-debug no longer enable sanitizers, we need explicit
> --enable-sanitizers.
>
> llvm package is required for llvm-symbolizer, to get symbols in
> backtraces.
>
> Add make V=1 to get details about failing tests.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  tests/docker/dockerfiles/fedora.docker | 2 +-
>  tests/docker/test-debug                | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/docker/dockerfiles/fedora.docker 
> b/tests/docker/dockerfiles/fedora.docker
> index 994a35a332..a00004319e 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -2,7 +2,7 @@ FROM fedora:27
>  ENV PACKAGES \
>      ccache gettext git tar PyYAML sparse flex bison python3 bzip2 hostname \
>      glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \
> -    gcc gcc-c++ clang make perl which bc findutils libaio-devel \
> +    gcc gcc-c++ llvm clang make perl which bc findutils libaio-devel \
>      nettle-devel libasan libubsan \
>      mingw32-pixman mingw32-glib2 mingw32-gmp mingw32-SDL mingw32-pkg-config \
>      mingw32-gtk2 mingw32-gtk3 mingw32-gnutls mingw32-nettle mingw32-libtasn1 
> \
> diff --git a/tests/docker/test-debug b/tests/docker/test-debug
> index d020b06917..d3f9f70d01 100755
> --- a/tests/docker/test-debug
> +++ b/tests/docker/test-debug
> @@ -1,6 +1,6 @@
>  #!/bin/bash -e
>  #
> -# Compile and check with clang & --enable-debug.
> +# Compile and check with clang & --enable-debug --enable-sanitizers.
>  #
>  # Copyright (c) 2016-2018 Red Hat Inc.
>  #
> @@ -19,8 +19,8 @@ requires clang asan
>  cd "$BUILD_DIR"
>
>  OPTS="--cxx=clang++ --cc=clang --host-cc=clang"
> -OPTS="--enable-debug $OPTS"
> +OPTS="--enable-debug --enable-sanitizers $OPTS"
>
>  build_qemu $OPTS
> -make $MAKEFLAGS check
> +make $MAKEFLAGS V=1 check
>  install_qemu
> --
> 2.16.2.346.g9779355e34
>
>



-- 
Marc-André Lureau