qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 6/9] nbd: BLOCK_STATUS for standard get_block_st


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [Qemu-devel] [PATCH 6/9] nbd: BLOCK_STATUS for standard get_block_status function: client part
Date: Mon, 12 Mar 2018 12:06:34 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

16.02.2018 23:40, Eric Blake wrote:
On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote:
Minimal realization: only one extent in server answer is supported.
Flag NBD_CMD_FLAG_REQ_ONE is used to force this behavior.

Tests 140, 147 and 205 are fixed due to now server failed on searching
export in context of NBD_OPT_SET_META_CONTEXT option negotiation.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---


[...]

+
  static int nbd_co_request(BlockDriverState *bs, NBDRequest *request,
                            QEMUIOVector *write_qiov)
  {
@@ -784,6 +878,50 @@ int nbd_client_co_pdiscard(BlockDriverState *bs, int64_t offset, int bytes)
      return nbd_co_request(bs, &request, NULL);
  }
  +int64_t coroutine_fn nbd_client_co_get_block_status(BlockDriverState *bs,
+                                                    int64_t sector_num,
+                                                    int nb_sectors, int *pnum,
+ BlockDriverState **file)

Needs rebasing on top of Kevin's block branch to use the byte-based interface.  I also need to finish up my promised followups on that series, as NBD (and other protocol drivers) should have consistent behavior on what it means to report OFFSET_VALID (or whether that should be limited to just format/filter drivers).

Looks like it's already in master, so I should just rebase on master.--

Best regards,
Vladimir




reply via email to

[Prev in Thread] Current Thread [Next in Thread]