Re: [Qemu-devel] [PATCH v8 17/23] qapi: introduce new cmd option "allow-oob"

[Peter Xu]

On Sat, Mar 10, 2018 at 08:27:22PM -0600, Eric Blake wrote:

[...]

> I'm a bit disappointed that tests/qapi-schema/qapi-schema-test.json doesn't
> have any "allow-oob":true commands at any point in the series. I consider
> that to be a bug, so it can be fixed by followup patch even after soft
> freeze; but won't make the lack of good testing hold up this series from
> making the release.

Sorry, obviously I missed that one.

If this series will reach master soon, I'll post separate patch for
that before release as bugfix.

If this series can't make it due to any reason, I'll append a patch to
the series when repost.

> 
> > +++ b/scripts/qapi/introspect.py
> > @@ -29,6 +29,11 @@ def to_json(obj, level=0):
> >                                 to_json(obj[key], level + 1))
> >                   for key in sorted(obj.keys())]
> >           ret = '{' + ', '.join(elts) + '}'
> > +    elif isinstance(obj, bool):
> > +        if obj:
> > +            ret = 'true'
> > +        else:
> > +            ret = 'false'
> 
> Conflicts with Marc-Andre's work to perform introspection by QLIT_*; but
> it's easy enough to adjust:
> 
> +    elif isinstance(obj, bool):
> +        ret += 'QLIT_QBOOL(%s)' % ('true' if obj else 'false')
> 
> Reviewed-by: Eric Blake <address@hidden>

Thanks,

-- 
Peter Xu